[SPARK-40836][CONNECT] AnalyzeResult should use struct for schema #38301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
amaliujia
force-pushed
the
return_schema_use_struct
branch
2 times, most recently
from
7cb9507 to
9c7617b
Compare
Contributor
There was a problem hiding this comment.
nit: for readability, move this to the other int type?
|
Can one of the admins verify this patch? |
amaliujia
force-pushed
the
return_schema_use_struct
branch
from
9c7617b to
4d3a83f
Compare
Contributor
Author
|
R: @cloud-fan |
amaliujia
force-pushed
the
return_schema_use_struct
branch
from
4d3a83f to
c6bd24e
Compare
cloud-fan
reviewed
Oct 24, 2022
Contributor
There was a problem hiding this comment.
we also need to set nullablity.
Contributor
Author
There was a problem hiding this comment.
ok let me fix the nullability in this PR then. Maybe it is a right time now.
Contributor
Author
There was a problem hiding this comment.
Entire nullability is ignored so far in current Connect implementation.
Contributor
Author
There was a problem hiding this comment.
Done. I set nullablity now.
cloud-fan
reviewed
Oct 24, 2022
amaliujia
force-pushed
the
return_schema_use_struct
branch
from
6faa578 to
bfcd053
Compare
Contributor
|
thanks, merging to master! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This PR replace column names and columns type with a schema (which is a struct). ### Why are the changes needed? Before this PR, AnalyzeResult separates column names and column types. However these two can be combined to form a schema which is a struct. This PR will simplify that proto message. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38301 from amaliujia/return_schema_use_struct. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replace column names and columns type with a schema (which is a struct).
Why are the changes needed?
Before this PR, AnalyzeResult separates column names and column types. However these two can be combined to form a schema which is a struct. This PR will simplify that proto message.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT