[SPARK-40812][CONNECT][PYTHON][FOLLOW-UP] Improve Deduplicate in Python client #38327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
amaliujia
changed the title
|
Can one of the admins verify this patch? |
amaliujia
force-pushed
the
python_deduplicate
branch
from
10889b5 to
f218c70
Compare
HyukjinKwon
approved these changes
Oct 24, 2022
HyukjinKwon
reviewed
Oct 24, 2022
| """ | ||
| if subset is None: | ||
| return DataFrame.withPlan( | ||
| plan.Deduplicate(child=self._plan, all_columns_as_keys=True), session=self._session |
cloud-fan
approved these changes
Oct 24, 2022
Contributor
|
thanks, merging to master! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…on client ### What changes were proposed in this pull request? Following up on apache#38276, this PR improve both `distinct()` and `dropDuplicates` DataFrame API in Python client, which both depends on `Deduplicate` plan in the Connect proto. ### Why are the changes needed? Improve API coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38327 from amaliujia/python_deduplicate. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Following up on #38276, this PR improve both
distinct()anddropDuplicatesDataFrame API in Python client, which both depends onDeduplicateplan in the Connect proto.Why are the changes needed?
Improve API coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT