[SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified #38354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Oct 23, 2022
.github/workflows/build_and_test.yml
Outdated
Member
There was a problem hiding this comment.
Default to temurin maybe? I thought that was the more 'standard' one but I don't know
Member
Author
There was a problem hiding this comment.
Yes, temurin is more 'standard', zulu is default used in v1, so I kept it same. But I also think temurin no problem. Let's see others idea.
cc @HyukjinKwon
Member
There was a problem hiding this comment.
Yeah, I think it;s fine to switch to temurin.
Member
Author
|
CI passed, will merge soon |
Member
Author
|
@srowen @HyukjinKwon @LuciferYang Thanks all, merged to master (3.4.0). |
5 tasks
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…on specified ### What changes were proposed in this pull request? Upgrade actions/setup-java to v3 with distribution specified ### Why are the changes needed? - The `distribution` is required after v2, now just keep `zulu` (same distribution with v1): https://github.com/actions/setup-java/releases/tag/v2.0.0 - https://github.com/actions/setup-java/releases/tag/v3.0.0: Upgrade node - https://github.com/actions/setup-java/releases/tag/v3.6.0: Cleanup set-output warning ### Does this PR introduce _any_ user-facing change? No,dev only ### How was this patch tested? CI passed Closes apache#38354 from Yikun/SPARK-40882. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade actions/setup-java to v3 with distribution specified
Why are the changes needed?
distributionis required after v2, now just keepzulu(same distribution with v1): https://github.com/actions/setup-java/releases/tag/v2.0.0Does this PR introduce any user-facing change?
No,dev only
How was this patch tested?
CI passed