[SPARK-40949][CONNECT][PYTHON] Implement DataFrame.sortWithinPartitions
#38423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Oct 28, 2022
Contributor
Author
There was a problem hiding this comment.
unfortunately, global is a Python keyword, so name it as is_global
HyukjinKwon
approved these changes
Oct 31, 2022
zhengruifeng
force-pushed
the
connect_df_sortWithinPartitions
branch
3 times, most recently
from
491dd83 to
94c775d
Compare
zhengruifeng
force-pushed
the
connect_df_sortWithinPartitions
branch
from
94c775d to
13f4830
Compare
Contributor
Author
|
the 3 force pushes only resolved conflicts in generated files, let me merge it now |
Contributor
Author
|
merged into master, thanks @HyukjinKwon |
Contributor
|
Late LGTM thanks |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ons` ### What changes were proposed in this pull request? Implement `DataFrame.sortWithinPartitions` ### Why are the changes needed? for api coverage ### Does this PR introduce _any_ user-facing change? yes, new method ### How was this patch tested? added UT Closes apache#38423 from zhengruifeng/connect_df_sortWithinPartitions. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement
DataFrame.sortWithinPartitionsWhy are the changes needed?
for api coverage
Does this PR introduce any user-facing change?
yes, new method
How was this patch tested?
added UT