[SPARK-40953][CONNECT][PYTHON] Fix DataFrame.head to collect specified number of rows
#38424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Please file a JIRA issue and use in the PR title, @zhengruifeng .
zhengruifeng
changed the title
Dataframe.headDataframe.head
Contributor
Author
|
@dongjoon-hyun thanks for the reminder😄 |
HyukjinKwon
changed the title
Dataframe.headDataFrame.head to collect specified number of rows
HyukjinKwon
approved these changes
Oct 30, 2022
Member
|
Merged to master. |
Contributor
|
nice catch! |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 31, 2022
…head(n) ### What changes were proposed in this pull request? Following up on #38424, we can actually add a test case for `head(n)`. ### Why are the changes needed? Improve test coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes #38442 from amaliujia/follow-up-head-n. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ied number of rows ### What changes were proposed in this pull request? `head` should return `self.limit(n).toPandas()` instead of `self.toPandas()` ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes apache#38424 from zhengruifeng/connect_head_fix. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…head(n) ### What changes were proposed in this pull request? Following up on apache#38424, we can actually add a test case for `head(n)`. ### Why are the changes needed? Improve test coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38442 from amaliujia/follow-up-head-n. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
headshould returnself.limit(n).toPandas()instead ofself.toPandas()Why are the changes needed?
bugfix
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing tests