[SPARK-40800][SQL][FOLLOW-UP] Add a config to control whether to always inline one-row relation subquery #38429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan |
HyukjinKwon
reviewed
Oct 31, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
…onf.scala Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Contributor
|
thanks, merging to master! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ys inline one-row relation subquery ### What changes were proposed in this pull request? This PR is a follow-up for SPARK-40800. It introduces a new Spark config to control the behavior of whether to always inline one-row relation subquery: `spark.sql.optimizer.optimizeOneRowRelationSubquery.alwaysInline` (default: true). ### Why are the changes needed? To give users more flexibility to control the correlated subquery performance. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Edited existing unit tests. Closes apache#38429 from allisonwang-db/spark-40800-follow-up. Lead-authored-by: allisonwang-db <allison.wang@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up for SPARK-40800. It introduces a new Spark config to control the behavior of whether to always inline one-row relation subquery:
spark.sql.optimizer.optimizeOneRowRelationSubquery.alwaysInline(default: true).Why are the changes needed?
To give users more flexibility to control the correlated subquery performance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Edited existing unit tests.