[SPARK-40890][SQL][TESTS] Check error classes in DataSourceV2SQLSuite #38439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
Author
|
cc @MaxGekk |
MaxGekk
reviewed
Oct 31, 2022
| parameters = Map("cmd" -> sqlCommand)) | ||
| } | ||
|
|
||
| private def assertAnalysisErrorClass( |
Member
There was a problem hiding this comment.
Let's remove assertAnalysisErrorClass(), and use checkError() directly. You could introduce an method analysisException as we did before for ParseException
Comment on lines
68
to
76
| errorClass: String, | ||
| parameters: Map[String, String]): Unit = { | ||
| checkError( | ||
| exception = intercept[AnalysisException] { | ||
| sql(sqlStatement) | ||
| }, | ||
| errorClass = errorClass, | ||
| parameters = parameters | ||
| ) |
Member
There was a problem hiding this comment.
Let's introduce a helper method for this:
exception = intercept[AnalysisException] {
sql(sqlStatement)
},and invoke checkError directly.
Member
|
@panbingkun Please, fix the code style issue: |
Contributor
Author
Done. |
Member
|
It seems this is related to your changes: Most likely after 3c967f0, need to merge/rebase the master. |
Contributor
Author
Done, waiting for CI. |
Member
|
+1, LGTM. Merging to master. I ran the test locally. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This PR aims to replace 'intercept' with 'Check error classes' in DataSourceV2SQLSuite. ### Why are the changes needed? The changes improve the error framework. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the modified test suite: ``` $ build/sbt "test:testOnly *DataSourceV2SQLSuite" ``` Closes apache#38439 from panbingkun/SPARK-40890. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to replace 'intercept' with 'Check error classes' in DataSourceV2SQLSuite.
Why are the changes needed?
The changes improve the error framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suite: