[SPARK-40827][PS][TESTS] Re-enable the DataFrame.corrwith test after fixing in future pandas. #38455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixing in future pandas.
HyukjinKwon
approved these changes
Nov 1, 2022
HyukjinKwon
changed the title
Contributor
Author
|
Thanks for the review :-) |
dongjoon-hyun
approved these changes
Nov 1, 2022
Member
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…fixing in future pandas ### What changes were proposed in this pull request? This PR proposes to make the manual tests for `DataFrame.corrwith` back into formal approach, if the pandas version is not 1.5.0. ### Why are the changes needed? There was a regression introduced by pandas 1.5.0 (pandas-dev/pandas#48826), and seems it's resolved now. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The fixed test should pass the CI. Closes apache#38455 from itholic/SPARK-40827. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make the manual tests for
DataFrame.corrwithback into formal approach, if the pandas version is not 1.5.0.Why are the changes needed?
There was a regression introduced by pandas 1.5.0 (pandas-dev/pandas#48826), and seems it's resolved now.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The fixed test should pass the CI.