Skip to content

Conversation

@amaliujia
Copy link
Contributor

What changes were proposed in this pull request?

This PR adds def sql(sqlText: String) to DSL and test the SQL proto with SparkSession/DataFrame.

Why are the changes needed?

Improve testing coverage.

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

@amaliujia amaliujia changed the title [SPARK-40980][CONNECT] Support session.sql in Connect DSL [SPARK-40980][CONNECT][DSL] Support session.sql in Connect DSL Nov 1, 2022
@amaliujia
Copy link
Contributor Author

R: @cloud-fan

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@zhengruifeng zhengruifeng changed the title [SPARK-40980][CONNECT][DSL] Support session.sql in Connect DSL [SPARK-40980][CONNECT][TEST] Support session.sql in Connect DSL Nov 1, 2022
@zhengruifeng
Copy link
Contributor

merged into master

SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?

This PR adds `def sql(sqlText: String)` to DSL and test the SQL proto with SparkSession/DataFrame.

### Why are the changes needed?

Improve testing coverage.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

UT

Closes apache#38459 from amaliujia/SPARK-40980.

Authored-by: Rui Wang <rui.wang@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants