Skip to content

[SPARK-40815][SQL][FOLLOW-UP] Disable DelegateSymlinkTextInputFormat tests for JDK 9+ #38504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sadikovi wants to merge 4 commits into from
Closed

[SPARK-40815][SQL][FOLLOW-UP] Disable DelegateSymlinkTextInputFormat tests for JDK 9+ #38504

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23e9f06
ignore the test
sadikovi Nov 3, 2022
01e6aac
disable the feature by default
sadikovi Nov 3, 2022
d6df480
ignore all of the tests for SPARK-40815
sadikovi Nov 3, 2022
5e3ebd0
use assume instead
sadikovi Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import java.nio.charset.StandardCharsets
import java.nio.file.Files
import java.sql.{Date, Timestamp}

import org.apache.commons.lang3.{JavaVersion, SystemUtils}
import org.apache.hadoop.fs.Path
import org.apache.hadoop.hive.ql.io.{DelegateSymlinkTextInputFormat, SymlinkTextInputFormat}
import org.apache.hadoop.mapred.FileSplit;
Expand Down Expand Up @@ -227,6 +228,9 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
}

test("SPARK-40815: DelegateSymlinkTextInputFormat serialization") {
// Ignored due to JDK 11 failures reported in https://github.com/apache/spark/pull/38277.
assume(!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))

def assertSerDe(split: DelegateSymlinkTextInputFormat.DelegateSymlinkTextInputSplit): Unit = {
val buf = new ByteArrayOutputStream()
val out = new DataOutputStream(buf)
Expand Down Expand Up @@ -262,6 +266,9 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
}

test("SPARK-40815: Read SymlinkTextInputFormat") {
// Ignored due to JDK 11 failures reported in https://github.com/apache/spark/pull/38277.
assume(!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))

withTable("t") {
withTempDir { root =>
val dataPath = new File(root, "data")
Expand Down