[SPARK-40877][DOC][FOLLOW-UP] Update the doc of DataFrame.stat.crosstab
#38579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HyukjinKwon |
HyukjinKwon
reviewed
Nov 10, 2022
| """ | ||
| Computes a pair-wise frequency table of the given columns. Also known as a contingency | ||
| table. The number of distinct values for each column should be less than 1e4. At most 1e6 | ||
| non-zero pair frequencies will be returned. |
Member
There was a problem hiding this comment.
I think we can just remove this and don't add .. versionchanged:: 3.4.0. It's sort of improvement, and trivial to mention.
HyukjinKwon
reviewed
Nov 10, 2022
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Contributor
Author
|
merged into master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…tab ` ### What changes were proposed in this pull request? remove the outdated comments ### Why are the changes needed? the limitations are not true after [reimplementation](apache#38340) ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? doc - only Closes apache#38579 from zhengruifeng/doc_crosstab. Lead-authored-by: Ruifeng Zheng <ruifengz@apache.org> Co-authored-by: Ruifeng Zheng <ruifengz@foxmail.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remove the outdated comments
Why are the changes needed?
the limitations are not true after reimplementation
Does this PR introduce any user-facing change?
yes
How was this patch tested?
doc - only