Skip to content

[SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread #38654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 2 commits into from
Closed

[SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread #38654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26bb8ae
init
zhengruifeng Nov 14, 2022
d176f3b
Update connector/connect/src/main/scala/org/apache/spark/sql/connect/…
zhengruifeng Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...nnect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,12 @@ class SparkConnectStreamHandler(responseObserver: StreamObserver[Response]) exte
resultHandler = resultHandler,
resultFunc = () => ())

// The man thread will wait until 0-th partition is available,
// The main thread will wait until 0-th partition is available,
// then send it to client and wait for the next partition.
// Different from the implementation of [[Dataset#collectAsArrowToPython]], it sends
// the arrow batches in main thread to avoid DAGScheduler thread been blocked for
// tasks not related to scheduling. This is particularly important if there are
// multiple users or clients running code at the same time.
var currentPartitionId = 0
while (currentPartitionId < numPartitions) {
val partition = signal.synchronized {
Expand Down