Skip to content

Conversation

@WangTaoTheTonic
Copy link
Contributor

@SparkQA
Copy link

SparkQA commented Jan 2, 2015

Test build #24993 has started for PR 3875 at commit 706c8a7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 2, 2015

Test build #24993 has finished for PR 3875 at commit 706c8a7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24993/
Test PASSed.

@ash211
Copy link
Contributor

ash211 commented Jan 2, 2015

Matches error message from 20 lines up, so LGTM

@JoshRosen
Copy link
Contributor

I suppose it'd be nice to use string interpolation here, but I guess the old code didn't use it either, so this matches the surrounding style

@WangTaoTheTonic
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jan 3, 2015

Test build #25010 has started for PR 3875 at commit 1503487.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 3, 2015

Test build #25010 has finished for PR 3875 at commit 1503487.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25010/
Test PASSed.

@WangTaoTheTonic
Copy link
Contributor Author

@JoshRosen I also think it's better to use string interpolation. In this class some places use interpolation while others don't. So I changed those who don't to keep consistent.

@WangTaoTheTonic
Copy link
Contributor Author

@JoshRosen Then is it ok?

@JoshRosen
Copy link
Contributor

LGTM, so I'll pull this into master (1.3.0).

@asfgit asfgit closed this in ce39b34 Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants