-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-5057]Add more details in log when using actor to get infos #3875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #24993 has started for PR 3875 at commit
|
|
Test build #24993 has finished for PR 3875 at commit
|
|
Test PASSed. |
|
Matches error message from 20 lines up, so LGTM |
|
I suppose it'd be nice to use string interpolation here, but I guess the old code didn't use it either, so this matches the surrounding style |
|
Jenkins, test this please. |
|
Test build #25010 has started for PR 3875 at commit
|
|
Test build #25010 has finished for PR 3875 at commit
|
|
Test PASSed. |
|
@JoshRosen I also think it's better to use string interpolation. In this class some places use interpolation while others don't. So I changed those who don't to keep consistent. |
|
@JoshRosen Then is it ok? |
|
LGTM, so I'll pull this into |
https://issues.apache.org/jira/browse/SPARK-5057