[SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions. #38762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
HyukjinKwon
approved these changes
Nov 23, 2022
|
|
||
| def localCheckpoint(self, *args: Any, **kwargs: Any) -> None: | ||
| raise NotImplementedError("localCheckpoint() is not implemented.") | ||
|
|
Contributor
There was a problem hiding this comment.
I think we also do not support to_pandas_on_spark, pandas_api, registerTempTable , storageLevel, mapInPandas, mapInArrow , writeStream
Contributor
Author
There was a problem hiding this comment.
ack will add those
amaliujia
reviewed
Nov 23, 2022
| self._session.execute_command(command) | ||
|
|
||
| def rdd(self, *args: Any, **kwargs: Any) -> None: | ||
| raise NotImplementedError("RDD Support for Spark Connect is not implemented.") |
Contributor
There was a problem hiding this comment.
Maybe keep consistently to include for Spark Connect or not include it in the error message?
Either is fine.
Only this one mentions Spark Connect now.
Contributor
Author
There was a problem hiding this comment.
While we might implement the others, here I want to be really specific about not being part of Spark Connect.
Contributor
|
LGTM |
Contributor
|
merged into master |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? For the better user experience we need to properly throw exceptions for functions that are not supported in Spark Connect. ### Why are the changes needed? User Experience ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38762 from grundprinzip/SPARK-41225. Authored-by: Martin Grund <martin.grund@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? For the better user experience we need to properly throw exceptions for functions that are not supported in Spark Connect. ### Why are the changes needed? User Experience ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38762 from grundprinzip/SPARK-41225. Authored-by: Martin Grund <martin.grund@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For the better user experience we need to properly throw exceptions for functions that are not supported in Spark Connect.
Why are the changes needed?
User Experience
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT