[SPARK-41250][CONNECT][PYTHON] DataFrame. toPandas should not return optional pandas dataframe #38786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optional pandas dataframe.
Contributor
Author
amaliujia
changed the title
grundprinzip
approved these changes
Nov 24, 2022
HyukjinKwon
approved these changes
Nov 24, 2022
Member
|
Merged to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…optional pandas dataframe ### What changes were proposed in this pull request? The server guarantees to send at least one arrow batch with schema even there is empty result. In this case, `DataFrame. toPandas` always can return a Pandas DataFrame. This PR decouples the client side execution path for `Command` and `Relation` to remove `Optional` from the returneed type of `DataFrame. toPandas `. ### Why are the changes needed? API coverage. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#38786 from amaliujia/returned_pandas_not_optional. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…optional pandas dataframe ### What changes were proposed in this pull request? The server guarantees to send at least one arrow batch with schema even there is empty result. In this case, `DataFrame. toPandas` always can return a Pandas DataFrame. This PR decouples the client side execution path for `Command` and `Relation` to remove `Optional` from the returneed type of `DataFrame. toPandas `. ### Why are the changes needed? API coverage. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#38786 from amaliujia/returned_pandas_not_optional. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The server guarantees to send at least one arrow batch with schema even there is empty result. In this case,
DataFrame. toPandasalways can return a Pandas DataFrame.This PR decouples the client side execution path for
CommandandRelationto removeOptionalfrom the returneed type ofDataFrame. toPandas.Why are the changes needed?
API coverage.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT