Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Jan 4, 2015

A simple fix would be adding assert(e1.appId == e2.appId) for SparkListenerApplicationStart. But actually we can use === for well-defined case class directly. Therefore, instead of fixing this issue, I use === to compare those well-defined case classes (all fields have implemented a correct equals method, such as primitive types)

@SparkQA
Copy link

SparkQA commented Jan 4, 2015

Test build #25024 has started for PR 3886 at commit 0a51711.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 4, 2015

Test build #25024 has finished for PR 3886 at commit 0a51711.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25024/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jan 5, 2015

LGTM. Merging in master. Thanks!

@asfgit asfgit closed this in 7239652 Jan 5, 2015
@zsxwing zsxwing deleted the SPARK-5067 branch January 5, 2015 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants