[DON'T MERGE][BUILD] Switch default protobuf-java version to 3.x #39255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Dec 28, 2022
| <artifactId>protobuf-java</artifactId> | ||
| <version>${protobuf.hadoopDependency.version}</version> | ||
| <scope>${hadoop.deps.scope}</scope> | ||
| <version>${protobuf.version}</version> |
Contributor
Author
There was a problem hiding this comment.
I have tested all maven test with -Phadoop-2 and -Phadoop-3, and all tests passed.
If feasible, we don't need to explicitly declare protobuf.version in each module that requires protobuf-java 3.x(such as core, sql, connect and protobuf), but this also changes protobuf-java version in dev/deps/spark-deps-hadoop-x-hive-2.3 from 2.5.0 to 3.x
Contributor
Author
There was a problem hiding this comment.
Of course, it may be safer to remove -Phadoop-2 completely before doing this work
Contributor
|
Are there anything we can do with this one? |
Contributor
|
oh.. #33133 the Guava problem.. |
Contributor
Author
|
@bjornjorgensen The pr is still being tested. I feel strange that the yarn module can pass the test with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?