[SPARK-41865][INFRA][3.2] Use pycodestyle to 2.7.0 to fix pycodestyle errors #39374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jan 4, 2023
Member
Author
|
Thank you, @HyukjinKwon . Although I checked this locally, I'll merge this after |
Member
Author
|
Oh, in CIs, all linters passed. I'll update the PR description and merge this.
|
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 4, 2023
… errors ### What changes were proposed in this pull request? `branch-3.2` has been broken for a while with false-positive failures. - https://github.com/apache/spark/actions/runs/3833643461/jobs/6525303096 ``` pycodestyle checks failed: ./python/pyspark/broadcast.py:102:23: E275 missing whitespace after keyword ./python/pyspark/sql/tests/test_context.py:166:19: E275 missing whitespace after keyword ./python/pyspark/sql/tests/test_pandas_udf_grouped_agg.py:512:15: E275 missing whitespace after keyword ./python/pyspark/sql/pandas/conversion.py:174:20: E275 missing whitespace after keyword ./python/pyspark/sql/readwriter.py:662:60: E275 missing whitespace after keyword ./python/pyspark/sql/readwriter.py:694:60: E275 missing whitespace after keyword ./python/pyspark/ml/tests/test_tuning.py:203:23: E275 missing whitespace after keyword ./python/pyspark/worker.py:583:27: E275 missing whitespace after keyword Error: Process completed with exit code 1. ``` ### Why are the changes needed? To fix `pycodestyle`. Apache Spark expects `2.7.0` like the following. https://github.com/apache/spark/blob/ad2d42709abfc8f8ad27f836c811a4b75ef32ee9/dev/lint-python#L25 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass `pycodestyle`.  Closes #39374 from dongjoon-hyun/SPARK-41865. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
It seems that |
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
… errors ### What changes were proposed in this pull request? `branch-3.2` has been broken for a while with false-positive failures. - https://github.com/apache/spark/actions/runs/3833643461/jobs/6525303096 ``` pycodestyle checks failed: ./python/pyspark/broadcast.py:102:23: E275 missing whitespace after keyword ./python/pyspark/sql/tests/test_context.py:166:19: E275 missing whitespace after keyword ./python/pyspark/sql/tests/test_pandas_udf_grouped_agg.py:512:15: E275 missing whitespace after keyword ./python/pyspark/sql/pandas/conversion.py:174:20: E275 missing whitespace after keyword ./python/pyspark/sql/readwriter.py:662:60: E275 missing whitespace after keyword ./python/pyspark/sql/readwriter.py:694:60: E275 missing whitespace after keyword ./python/pyspark/ml/tests/test_tuning.py:203:23: E275 missing whitespace after keyword ./python/pyspark/worker.py:583:27: E275 missing whitespace after keyword Error: Process completed with exit code 1. ``` ### Why are the changes needed? To fix `pycodestyle`. Apache Spark expects `2.7.0` like the following. https://github.com/apache/spark/blob/ad2d42709abfc8f8ad27f836c811a4b75ef32ee9/dev/lint-python#L25 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass `pycodestyle`.  Closes apache#39374 from dongjoon-hyun/SPARK-41865. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
branch-3.2has been broken for a while with false-positive failures.Why are the changes needed?
To fix
pycodestyle. Apache Spark expects2.7.0like the following.spark/dev/lint-python
Line 25 in ad2d427
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass
pycodestyle.