[SPARK-42108][SQL] Make Analyzer transform Count(*) into Count(1)
#39636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
COUNT(*) -> COUNT(1) to AnalyzerCOUNT(*) -> COUNT(1) to Analyzer
cloud-fan
approved these changes
Jan 18, 2023
Contributor
|
@zhengruifeng can you fill the PR description and remove WIP? |
HyukjinKwon
approved these changes
Jan 18, 2023
HyukjinKwon
approved these changes
Jan 18, 2023
zhengruifeng
force-pushed
the
sql_move_count_star
branch
from
84b367b to
90088c7
Compare
zhengruifeng
changed the title
COUNT(*) -> COUNT(1) to AnalyzerCount(*) into Count(1)
Contributor
Author
|
@cloud-fan I found that removing the |
Contributor
Author
|
all tests passed, minding taking another look? @cloud-fan @HyukjinKwon |
dongjoon-hyun
approved these changes
Jan 19, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
cc @huaxingao , @sunchao , too
Contributor
|
thanks, merging to master! |
Contributor
Author
|
thank you @dongjoon-hyun @cloud-fan @HyukjinKwon |
zhengruifeng
added a commit
that referenced
this pull request
Jan 21, 2023
…(col(*))`
### What changes were proposed in this pull request?
1, add `UnresolvedStar` to `expressions.py`;
2, Fix `count(*)` and `count(col(*))`, should return `Column(UnresolvedStar(None))` instead of `Column(UnresolvedAttribute("*"))`, see: https://github.com/apache/spark/blob/68531ada34db72d352c39396f85458a8370af812/sql/core/src/main/scala/org/apache/spark/sql/Column.scala#L144-L150
3, remove the `count(*) -> count(1)` transformation in `group.py`, since it's no longer needed.
### Why are the changes needed?
#39636 fixed the `count(*)` issue in the server side, and then `count(expr(*))` works after that PR.
This PR makes the corresponding changes in the Python Client side, in order to support `count(*)`, and `count(col(*))`
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
enabled UT and added UT
Closes #39622 from zhengruifeng/connect_count_star.
Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make Analyzer transform
Count(*)intoCount(1)Why are the changes needed?
Existing
Count(*) -> Count(1)transformation happens inAstBuilder.visitFunctionCall.The Analyzer requires the
Count(*)had already been converted toCount(1)in Parser, and for a givenCount(*)expression, the Analyzer itself can not correctly handle it and cause correctness issue in Spark Connect (see https://issues.apache.org/jira/browse/SPARK-41845)Does this PR introduce any user-facing change?
No
How was this patch tested?
added UT, manually test with Spark Connect