Skip to content

[SPARK-1143] Separate pool tests into their own suite. #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kayousterhout wants to merge 1 commit into from
Closed

[SPARK-1143] Separate pool tests into their own suite. #3967

kayousterhout wants to merge 1 commit into from

Conversation

@kayousterhout
Copy link
Contributor

@kayousterhout kayousterhout commented Jan 9, 2015

The current TaskSchedulerImplSuite includes some tests that are
actually for the TaskSchedulerImpl, but the remainder of the tests avoid using
the TaskSchedulerImpl entirely, and actually test the pool and scheduling
algorithm mechanisms. This commit separates the pool/scheduling algorithm
tests into their own suite, and also simplifies those tests.

The pull request replaces #339.

@kayousterhout
[SPARK-1143] Separate pool tests into their own suite.
8a898c4 
The current TaskSchedulerImplSuite includes some tests that are
actually for the TaskSchedulerImpl, but many of the tests avoid using
the TaskSchedulerImpl entirely, and actually test the pool and scheduling
algorithm mechanisms. This commit separates the pool/scheduling algorithm
tests into their own suite, simplifies those tests, and attempts to
more helpfully comment the fair scheduler test.

The pull request replaces apache#339.
@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25300 has started for PR 3967 at commit 8a898c4.

  • This patch merges cleanly.

@rxin
Copy link
Contributor

rxin commented Jan 9, 2015

LGTM ...

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25300 has finished for PR 3967 at commit 8a898c4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PoolSuite extends FunSuite with LocalSparkContext

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 9, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25300/
Test FAILed.

@kayousterhout
Copy link
Contributor Author

kayousterhout commented Jan 9, 2015

Jenkins, retest this please

@kayousterhout
Copy link
Contributor Author

kayousterhout commented Jan 9, 2015

@tdas what's the status with these (seemingly unreliable) Kafka tests? Should they be disabled?

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25308 has started for PR 3967 at commit 8a898c4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 9, 2015

Test build #25308 has finished for PR 3967 at commit 8a898c4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PoolSuite extends FunSuite with LocalSparkContext

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 9, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25308/
Test PASSed.

@pwendell
Copy link
Contributor

pwendell commented Jan 9, 2015

Looks good, 'Ill pull it in.

@asfgit asfgit closed this in b6aa557 Jan 9, 2015
@kayousterhout kayousterhout deleted the SPARK-1143 branch January 19, 2015 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kayousterhout @SparkQA @rxin @AmplabJenkins @pwendell