[WIP] Move ClientE2ETestSuite into a separate module #39788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jan 29, 2023
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.spark</groupId> | ||
| <artifactId>spark-connect_${scala.binary.version}</artifactId> |
Contributor
Author
There was a problem hiding this comment.
should be <scope>test</scope>
LuciferYang
commented
Jan 29, 2023
| <scope>test</scope> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> |
Contributor
Author
There was a problem hiding this comment.
should be <scope>test</scope>
LuciferYang
commented
Jan 29, 2023
|
|
||
| object SparkConnectClientTests { | ||
| lazy val settings = Seq( | ||
| excludeDependencies ++= { |
Contributor
Author
There was a problem hiding this comment.
excludeDependencies does not work. There is a probability that sbt will fail to compile because spark-sql is in the classpath, which will cause package conflicts as follows:
[error] /${basedir}/spark-mine/connector/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:27:21: value collectResult is not a member of org.apache.spark.sql.DataFrame
[error] val schema = df.collectResult().schema
[error] ^
[error] /${basedir}/spark-mine/connector/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:33:21: value collectResult is not a member of org.apache.spark.sql.DataFrame
[error] val result = df.collectResult()
[error] ^
[error] /${basedir}/spark-mine/connector/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:43:21: value collectResult is not a member of org.apache.spark.sql.Dataset[Long]
[error] val result = df.collectResult()
[error] ^
[error] /${basedir}/spark-mine/connector/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala:152:36: value client is not a member of org.apache.spark.sql.SparkSession.Builder
[error] spark = SparkSession.builder().client(SparkConnectClient.builder().port(port).build()).build()
[error] ^
[error] /${basedir}/spark-mine/connector/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala:165:12: value collectResult is not a member of org.apache.spark.sql.DataFrame
[error] possible cause: maybe a semicolon is missing before `value collectResult'?
[error] .collectResult()
[error] ^
[error] 5 errors found
[error] (connect-client-integration-tests / Test / compileIncremental) Compilation failed
[error] Total time: 47 s, completed 2023-1-29 12:41:23
I can't solve it temporarily
Contributor
Author
|
Just trying. Currently, I haven't fully figured out how to do it better |
Contributor
Author
|
close this one and open #39807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?