[SPARK-42244][PYTHON] Refine error classes and messages #39815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@HyukjinKwon could you take a look at this when you find some time? |
HyukjinKwon
approved these changes
Feb 8, 2023
Member
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 8, 2023
### What changes were proposed in this pull request? This PR proposes to refine error classes and messages by using the Python type object name for error class name and its messages. nit - Also add missing dots at the end of error messages. ### Why are the changes needed? The type name was inconsistent in the previous error messages, e.g. string and str, int and integer, and the sometimes the error class name is too long to read. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass. Closes #39815 from itholic/SPARK-42244. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 839c56a) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 8, 2023
…tency ### What changes were proposed in this pull request? This PR follow-ups for #39815 to fix error messages that's not meet the consistency with other error messages. ### Why are the changes needed? To keep the consistency across all error messages. ### Does this PR introduce _any_ user-facing change? No, error message changes. ### How was this patch tested? The existing CI should pass. Closes #39935 from itholic/SPARK-42244-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 8, 2023
…tency ### What changes were proposed in this pull request? This PR follow-ups for #39815 to fix error messages that's not meet the consistency with other error messages. ### Why are the changes needed? To keep the consistency across all error messages. ### Does this PR introduce _any_ user-facing change? No, error message changes. ### How was this patch tested? The existing CI should pass. Closes #39935 from itholic/SPARK-42244-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 7dbf9f6) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR proposes to refine error classes and messages by using the Python type object name for error class name and its messages. nit - Also add missing dots at the end of error messages. ### Why are the changes needed? The type name was inconsistent in the previous error messages, e.g. string and str, int and integer, and the sometimes the error class name is too long to read. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass. Closes apache#39815 from itholic/SPARK-42244. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 839c56a) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…tency ### What changes were proposed in this pull request? This PR follow-ups for apache#39815 to fix error messages that's not meet the consistency with other error messages. ### Why are the changes needed? To keep the consistency across all error messages. ### Does this PR introduce _any_ user-facing change? No, error message changes. ### How was this patch tested? The existing CI should pass. Closes apache#39935 from itholic/SPARK-42244-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 7dbf9f6) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to refine error classes and messages by using the Python type object name for error class name and its messages.
nit - Also add missing dots at the end of error messages.
Why are the changes needed?
The type name was inconsistent in the previous error messages, e.g. string and str, int and integer, and the sometimes the error class name is too long to read.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The existing CI should pass.