[SPARK-42210][CONNECT][PYTHON] Standardize registered pickled Python UDFs #39860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
commented
Feb 2, 2023
Member
Author
There was a problem hiding this comment.
I would suggest renaming CommonInlineUserDefinedFunction to CommonUserDefinedFunction since both registered and inline-defined pickled Python UDFs may share the same proto. CC @HyukjinKwon @zhengruifeng @grundprinzip @hvanhovell
Member
Author
There was a problem hiding this comment.
After double thoughts, I may want to do the renaming in a separate PR for an easier review, considering Scala UDFs also depends on the CommonInlineUserDefinedFunction.
xinrong-meng
force-pushed
the
connect_registered_udf
branch
from
b562759 to
55a47ce
Compare
HyukjinKwon
approved these changes
Feb 3, 2023
Contributor
|
can we also remove |
xinrong-meng
force-pushed
the
connect_registered_udf
branch
from
d55b8ff to
da68c8a
Compare
Member
Author
|
Forced push to adjust the PR based on the latest master. |
xinrong-meng
changed the title
HyukjinKwon
approved these changes
Feb 8, 2023
zhengruifeng
approved these changes
Feb 8, 2023
zhengruifeng
reviewed
Feb 8, 2023
connector/connect/common/src/main/protobuf/spark/connect/commands.proto
Outdated
Show resolved
Hide resolved
Member
|
Oops, mind rebasing this please @xinrong-meng |
xinrong-meng
force-pushed
the
connect_registered_udf
branch
from
568ed71 to
3ad2b6d
Compare
Member
Author
|
Forced push to base on the latest master. |
Member
Author
|
Merged to branch-3.4 and master, thanks all! |
xinrong-meng
added a commit
that referenced
this pull request
Feb 9, 2023
…UDFs
### What changes were proposed in this pull request?
Standardize registered pickled Python UDFs, specifically, implement `spark.udf.register()`.
### Why are the changes needed?
To reach parity with vanilla PySpark.
### Does this PR introduce _any_ user-facing change?
Yes. `spark.udf.register()` is added as shown below:
```py
>>> spark.udf
<pyspark.sql.connect.udf.UDFRegistration object at 0x7fbca0077dc0>
>>> f = spark.udf.register("f", lambda x: x+1, "int")
>>> f
<function <lambda> at 0x7fbc905e5e50>
>>> spark.sql("SELECT f(id) FROM range(2)").collect()
[Row(f(id)=1), Row(f(id)=2)]
```
### How was this patch tested?
Unit tests.
Closes #39860 from xinrong-meng/connect_registered_udf.
Lead-authored-by: Xinrong Meng <xinrong@apache.org>
Co-authored-by: Xinrong Meng <xinrong.apache@gmail.com>
Signed-off-by: Xinrong Meng <xinrong@apache.org>
(cherry picked from commit e7eb836)
Signed-off-by: Xinrong Meng <xinrong@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…UDFs
### What changes were proposed in this pull request?
Standardize registered pickled Python UDFs, specifically, implement `spark.udf.register()`.
### Why are the changes needed?
To reach parity with vanilla PySpark.
### Does this PR introduce _any_ user-facing change?
Yes. `spark.udf.register()` is added as shown below:
```py
>>> spark.udf
<pyspark.sql.connect.udf.UDFRegistration object at 0x7fbca0077dc0>
>>> f = spark.udf.register("f", lambda x: x+1, "int")
>>> f
<function <lambda> at 0x7fbc905e5e50>
>>> spark.sql("SELECT f(id) FROM range(2)").collect()
[Row(f(id)=1), Row(f(id)=2)]
```
### How was this patch tested?
Unit tests.
Closes apache#39860 from xinrong-meng/connect_registered_udf.
Lead-authored-by: Xinrong Meng <xinrong@apache.org>
Co-authored-by: Xinrong Meng <xinrong.apache@gmail.com>
Signed-off-by: Xinrong Meng <xinrong@apache.org>
(cherry picked from commit e7eb836)
Signed-off-by: Xinrong Meng <xinrong@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Standardize registered pickled Python UDFs, specifically, implement
spark.udf.register().Why are the changes needed?
To reach parity with vanilla PySpark.
Does this PR introduce any user-facing change?
Yes.
spark.udf.register()is added as shown below:How was this patch tested?
Unit tests.
SPARK-41661