[SPARK-41600][SPARK-41623][SPARK-41612][CONNECT] Implement Catalog.cacheTable, isCached and uncache #39919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @zhengruifeng, @grundprinzip @ueshin FYI |
zhengruifeng
approved these changes
Feb 7, 2023
HyukjinKwon
force-pushed
the
SPARK-41600-SPARK-41623-SPARK-41612
branch
from
be8f9c9 to
d9de8a0
Compare
HyukjinKwon
force-pushed
the
SPARK-41600-SPARK-41623-SPARK-41612
branch
from
d9de8a0 to
a9d85f0
Compare
HyukjinKwon
commented
Feb 7, 2023
HyukjinKwon
force-pushed
the
SPARK-41600-SPARK-41623-SPARK-41612
branch
from
a9d85f0 to
7f1f45c
Compare
HyukjinKwon
force-pushed
the
SPARK-41600-SPARK-41623-SPARK-41612
branch
from
7f1f45c to
bae11a1
Compare
HyukjinKwon
commented
Feb 7, 2023
| Throw an analysis exception when the table does not exist. | ||
| >>> spark.catalog.isCached("not_existing_table") | ||
| >>> spark.catalog.isCached("not_existing_table") # doctest: +SKIP |
Member
Author
There was a problem hiding this comment.
Should enable this back too once #39882 is merged.
Member
Author
|
Merged to master and branch-3.4. |
Member
Author
|
Thank you guys. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 7, 2023
…cheTable, isCached and uncache ### What changes were proposed in this pull request? This PR adds three API below to Spark Connect - `Catalog.isCached` - `Catalog.cacheTable` - `Catalog uncacheTable` ### Why are the changes needed? These were not added because of the design concern (in its behaviour). However, we should provide the same API compatibility and behaivours with the regular PySpark in any event. So these are proposed back. ### Does this PR introduce _any_ user-facing change? No to end users. Yes to the dev because it adds three new API in Spark Connect. ### How was this patch tested? Unittests were added. Closes #39919 from HyukjinKwon/SPARK-41600-SPARK-41623-SPARK-41612. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 54b5cf6) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…cheTable, isCached and uncache ### What changes were proposed in this pull request? This PR adds three API below to Spark Connect - `Catalog.isCached` - `Catalog.cacheTable` - `Catalog uncacheTable` ### Why are the changes needed? These were not added because of the design concern (in its behaviour). However, we should provide the same API compatibility and behaivours with the regular PySpark in any event. So these are proposed back. ### Does this PR introduce _any_ user-facing change? No to end users. Yes to the dev because it adds three new API in Spark Connect. ### How was this patch tested? Unittests were added. Closes apache#39919 from HyukjinKwon/SPARK-41600-SPARK-41623-SPARK-41612. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 54b5cf6) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds three API below to Spark Connect
Catalog.isCachedCatalog.cacheTableCatalog uncacheTableWhy are the changes needed?
These were not added because of the design concern (in its behaviour). However, we should provide the same API compatibility and behaivours with the regular PySpark in any event. So these are proposed back.
Does this PR introduce any user-facing change?
No to end users.
Yes to the dev because it adds three new API in Spark Connect.
How was this patch tested?
Unittests were added.