Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][SS]: Fix setTimeoutTimestamp doc #39958

Closed
wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Feb 9, 2023

What changes were proposed in this pull request?

This patch updates the API doc of setTimeoutTimestamp of GroupState.

Why are the changes needed?

Update incorrect API doc.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Doc change only.

@viirya viirya changed the title MINOR: Fix setTimeoutTimestamp doc [MINOR][SS]: Fix setTimeoutTimestamp doc Feb 9, 2023
@viirya
Copy link
Member Author

viirya commented Feb 10, 2023

Thank you @HyukjinKwon

@viirya viirya closed this in a180e67 Feb 10, 2023
viirya added a commit that referenced this pull request Feb 10, 2023
### What changes were proposed in this pull request?

This patch updates the API doc of `setTimeoutTimestamp` of `GroupState`.

### Why are the changes needed?

Update incorrect API doc.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Doc change only.

Closes #39958 from viirya/fix_group_state.

Authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
(cherry picked from commit a180e67)
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
viirya added a commit that referenced this pull request Feb 10, 2023
### What changes were proposed in this pull request?

This patch updates the API doc of `setTimeoutTimestamp` of `GroupState`.

### Why are the changes needed?

Update incorrect API doc.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Doc change only.

Closes #39958 from viirya/fix_group_state.

Authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
(cherry picked from commit a180e67)
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
viirya added a commit that referenced this pull request Feb 10, 2023
### What changes were proposed in this pull request?

This patch updates the API doc of `setTimeoutTimestamp` of `GroupState`.

### Why are the changes needed?

Update incorrect API doc.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Doc change only.

Closes #39958 from viirya/fix_group_state.

Authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
(cherry picked from commit a180e67)
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
@viirya
Copy link
Member Author

viirya commented Feb 10, 2023

Merged to master/3.4/3.3/3.2.

@viirya viirya deleted the fix_group_state branch February 10, 2023 06:21
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, late LGTM.

sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
### What changes were proposed in this pull request?

This patch updates the API doc of `setTimeoutTimestamp` of `GroupState`.

### Why are the changes needed?

Update incorrect API doc.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Doc change only.

Closes apache#39958 from viirya/fix_group_state.

Authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
(cherry picked from commit a180e67)
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
### What changes were proposed in this pull request?

This patch updates the API doc of `setTimeoutTimestamp` of `GroupState`.

### Why are the changes needed?

Update incorrect API doc.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Doc change only.

Closes apache#39958 from viirya/fix_group_state.

Authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
(cherry picked from commit a180e67)
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants