[SPARK-42419][CONNECT][PYTHON] Migrate into error framework for Spark Connect Column API. #39991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Connect column API.
Member
|
cc @MaxGekk would you mind taking a look please when you find some time. |
Member
|
@itholic mind fixing the test? |
Contributor
Author
|
Fixed the test. Thanks! |
amaliujia
reviewed
Feb 16, 2023
Member
|
Still fails. Mind fixing them please? |
Contributor
Author
|
FYI @HyukjinKwon CI passed! |
Contributor
|
LGTM |
HyukjinKwon
approved these changes
Feb 27, 2023
Member
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 27, 2023
… Connect Column API ### What changes were proposed in this pull request? This PR proposes to migrate `TypeError` into error framework for Spark Connect Column API. ### Why are the changes needed? To improve errors by leveraging the PySpark error framework for Spark Connect Column APIs. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Fixed & added UTs. Closes #39991 from itholic/SPARK-42419. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 86d3db9) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zhengruifeng
pushed a commit
that referenced
this pull request
Apr 25, 2023
### What changes were proposed in this pull request? This is follow-up for #39991 to remove unused exception. ### Why are the changes needed? `PySparkTypeError` never raises because we checked the type already in the codes above `if type(startPos) != type(length):` and raise `PySparkTypeError` for unsupported type for `length`. ### Does this PR introduce _any_ user-facing change? No. it's minor code cleanup ### How was this patch tested? The existing CI should pass. Closes #40927 from itholic/connect_col_followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
… Connect Column API ### What changes were proposed in this pull request? This PR proposes to migrate `TypeError` into error framework for Spark Connect Column API. ### Why are the changes needed? To improve errors by leveraging the PySpark error framework for Spark Connect Column APIs. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Fixed & added UTs. Closes apache#39991 from itholic/SPARK-42419. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 86d3db9) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to migrate
TypeErrorinto error framework for Spark Connect Column API.Why are the changes needed?
To improve errors by leveraging the PySpark error framework for Spark Connect Column APIs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Fixed & added UTs.