[SPARK-42342][PYTHON][CONNECT][TEST] Fix FunctionsParityTests.test_raise_error to call the proper test #40021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 14, 2023
Member
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 15, 2023
…ise_error to call the proper test ### What changes were proposed in this pull request? This is a follow-up of #39882. Fixes `FunctionsParityTests.test_raise_error` to call the proper test. ### Why are the changes needed? `FunctionsParityTests.test_raise_error` should've called `check_raise_error`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The fixed test. Closes #40021 from ueshin/issues/SPARK-42342/test. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 3ed1b95) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…ise_error to call the proper test ### What changes were proposed in this pull request? This is a follow-up of apache#39882. Fixes `FunctionsParityTests.test_raise_error` to call the proper test. ### Why are the changes needed? `FunctionsParityTests.test_raise_error` should've called `check_raise_error`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The fixed test. Closes apache#40021 from ueshin/issues/SPARK-42342/test. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 3ed1b95) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #39882.
Fixes
FunctionsParityTests.test_raise_errorto call the proper test.Why are the changes needed?
FunctionsParityTests.test_raise_errorshould've calledcheck_raise_error.Does this PR introduce any user-facing change?
No.
How was this patch tested?
The fixed test.