[SPARK-42465][CONNECT] ProtoToPlanTestSuite should use analyzed plans instead of parsed plans. #40056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
reviewed
Feb 16, 2023
| } | ||
|
|
||
| override def toString: String = target.map(_ + ".").getOrElse("") + "*" | ||
| override def toString: String = target.map(_.mkString("", ".", ".")).getOrElse("") + "*" |
Contributor
There was a problem hiding this comment.
Just wondering if this will be a kind of breaking change that some users use toString already to match plans, etc.
cc @cloud-fan
Contributor
Author
There was a problem hiding this comment.
this is already merged code. I hope they don't rely on this because moving from 2.12 to 2.13 would break their code.
# Conflicts: # connector/connect/common/src/test/resources/query-tests/explain-results/column_as_multi.explain # connector/connect/common/src/test/resources/query-tests/explain-results/column_star_with_target.explain # connector/connect/common/src/test/resources/query-tests/explain-results/join_inner_using_multiple_col_array.explain # connector/connect/common/src/test/resources/query-tests/explain-results/join_inner_using_multiple_col_seq.explain # connector/connect/common/src/test/resources/query-tests/explain-results/join_inner_using_single_col.explain # connector/connect/common/src/test/resources/query-tests/explain-results/join_using_multiple_col_array.explain # connector/connect/common/src/test/resources/query-tests/explain-results/join_using_multiple_col_seq.explain # connector/connect/common/src/test/resources/query-tests/explain-results/join_using_single_col.explain
Contributor
Author
|
For the reviews, I have manually tested this with 2.13. |
Contributor
Author
|
Alright merging this. |
hvanhovell
added a commit
that referenced
this pull request
Feb 16, 2023
… instead of parsed plans ### What changes were proposed in this pull request? This makes `ProtoToPlanTestSuite` use analyzed plans instead of parsed plans. ### Why are the changes needed? This is to increase the fidelity of the `ProtoToPlanTestSuite`, especially since we are going to be adding functions. Functions are special because the spark connect planner leaves them unresolved, the actual binding only happens in the analyzer. Without running the analyzer we would not know if the bindings are correct. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? It is a test change. Closes #40056 from hvanhovell/SPARK-42465. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 64aa84b) Signed-off-by: Herman van Hovell <herman@databricks.com>
Member
Thank you so much, @hvanhovell ! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
… instead of parsed plans ### What changes were proposed in this pull request? This makes `ProtoToPlanTestSuite` use analyzed plans instead of parsed plans. ### Why are the changes needed? This is to increase the fidelity of the `ProtoToPlanTestSuite`, especially since we are going to be adding functions. Functions are special because the spark connect planner leaves them unresolved, the actual binding only happens in the analyzer. Without running the analyzer we would not know if the bindings are correct. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? It is a test change. Closes apache#40056 from hvanhovell/SPARK-42465. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 64aa84b) Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This makes
ProtoToPlanTestSuiteuse analyzed plans instead of parsed plans.Why are the changes needed?
This is to increase the fidelity of the
ProtoToPlanTestSuite, especially since we are going to be adding functions. Functions are special because the spark connect planner leaves them unresolved, the actual binding only happens in the analyzer. Without running the analyzer we would not know if the bindings are correct.Does this PR introduce any user-facing change?
No
How was this patch tested?
It is a test change.