[SPARK-42482][CONNECT] Scala Client Write API V1 #40061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
reviewed
Feb 17, 2023
connector/connect/client/jvm/src/main/java/org/apache/spark/sql/SaveMode.java
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Feb 17, 2023
Contributor
There was a problem hiding this comment.
this is lazy. you need to call collect()
hvanhovell
reviewed
Feb 17, 2023
hvanhovell
reviewed
Feb 17, 2023
Contributor
There was a problem hiding this comment.
Do we need this conversion? That seems like an artifact from the original implementation.
hvanhovell
reviewed
Feb 17, 2023
Contributor
There was a problem hiding this comment.
pfff... this is clever. builder.hasPath != builder.hasTable might be easier to parse.
hvanhovell
reviewed
Feb 17, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Feb 17, 2023
hvanhovell
reviewed
Feb 17, 2023
Contributor
There was a problem hiding this comment.
Nah that is a server side problem.
hvanhovell
reviewed
Feb 17, 2023
Contributor
There was a problem hiding this comment.
We need more test coverage.
zhenlineo
changed the title
zhenlineo
changed the title
This reverts commit 7e112b2.
hvanhovell
pushed a commit
that referenced
this pull request
Feb 19, 2023
### What changes were proposed in this pull request? Implemented the basic Dataset#write API to allow users to write the df into tables, csv etc. files. ### Why are the changes needed? Basic write operation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Integration tests. Closes #40061 from zhenlineo/write. Authored-by: Zhen Li <zhenlineo@users.noreply.github.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit ede1a54) Signed-off-by: Herman van Hovell <herman@databricks.com>
hvanhovell
pushed a commit
that referenced
this pull request
Feb 22, 2023
### What changes were proposed in this pull request? Adding DataFrameWriterV2. This allows users to use the Dataset#writeTo API. ### Why are the changes needed? Impls Dataset#writeTo ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? E2E This is based on #40061 Closes #40075 from zhenlineo/write-v2. Authored-by: Zhen Li <zhenlineo@users.noreply.github.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
hvanhovell
pushed a commit
that referenced
this pull request
Feb 22, 2023
### What changes were proposed in this pull request? Adding DataFrameWriterV2. This allows users to use the Dataset#writeTo API. ### Why are the changes needed? Impls Dataset#writeTo ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? E2E This is based on #40061 Closes #40075 from zhenlineo/write-v2. Authored-by: Zhen Li <zhenlineo@users.noreply.github.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 0c4645e) Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Implemented the basic Dataset#write API to allow users to write the df into tables, csv etc. files. ### Why are the changes needed? Basic write operation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Integration tests. Closes apache#40061 from zhenlineo/write. Authored-by: Zhen Li <zhenlineo@users.noreply.github.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit ede1a54) Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Adding DataFrameWriterV2. This allows users to use the Dataset#writeTo API. ### Why are the changes needed? Impls Dataset#writeTo ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? E2E This is based on apache#40061 Closes apache#40075 from zhenlineo/write-v2. Authored-by: Zhen Li <zhenlineo@users.noreply.github.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 0c4645e) Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implemented the basic Dataset#write API to allow users to write the df into tables, csv etc. files.
Why are the changes needed?
Basic write operation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Integration tests.