[SPARK-42570][CONNECT][PYTHON] Fix DataFrameReader to use the default source #40166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
commented
Feb 25, 2023
| actual = self.spark.read.load(path=tmpPath) | ||
| self.assertEqual(sorted(df.collect()), sorted(actual.collect())) | ||
| self.spark.sql("SET spark.sql.sources.default=" + defaultDataSourceName) | ||
| try: |
Member
Author
There was a problem hiding this comment.
The changes in this file is to make the cleanup done properly.
Contributor
|
LGTM What is the default source BTW? |
amaliujia
reviewed
Feb 25, 2023
connector/connect/common/src/main/protobuf/spark/connect/relations.proto
Show resolved
Hide resolved
Member
Author
If format is not set, the value from SQL conf 'spark.sql.sources.default' will be used. |
Contributor
|
Merging. |
hvanhovell
pushed a commit
that referenced
this pull request
Feb 25, 2023
… source ### What changes were proposed in this pull request? Fixes `DataFrameReader` to use the default source. ### Why are the changes needed? ```py spark.read.load(path) ``` should work and use the default source without specifying the format. ### Does this PR introduce _any_ user-facing change? The `format` doesn't need to be specified. ### How was this patch tested? Enabled related tests. Closes #40166 from ueshin/issues/SPARK-42570/reader. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit ad35f35) Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
… source ### What changes were proposed in this pull request? Fixes `DataFrameReader` to use the default source. ### Why are the changes needed? ```py spark.read.load(path) ``` should work and use the default source without specifying the format. ### Does this PR introduce _any_ user-facing change? The `format` doesn't need to be specified. ### How was this patch tested? Enabled related tests. Closes apache#40166 from ueshin/issues/SPARK-42570/reader. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit ad35f35) Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes
DataFrameReaderto use the default source.Why are the changes needed?
should work and use the default source without specifying the format.
Does this PR introduce any user-facing change?
The
formatdoesn't need to be specified.How was this patch tested?
Enabled related tests.