[SPARK-42561][CONNECT] Add temp view API to Dataset #40167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
hvanhovell
reviewed
Feb 25, 2023
| new Dataset[T](this, plan) | ||
| } | ||
|
|
||
| private[sql] def newCommand[T](f: proto.Command.Builder => Unit): proto.Command = { |
Contributor
There was a problem hiding this comment.
Are we going to use this method else where? Otherwise it seems a bit much to add.
Contributor
Author
There was a problem hiding this comment.
I think for any other command related API, we can use it.
HyukjinKwon
reviewed
Feb 25, 2023
| * @group basic | ||
| * @since 3.4.0 | ||
| */ | ||
| @deprecated("Use createOrReplaceTempView(viewName) instead.", "2.0.0") |
Member
There was a problem hiding this comment.
BTW .. we should probably grep and replace these versions in deprecation (2.0.0 in this case) to 3.4.0 .. of course I don't mind doing separately.
Contributor
Author
There was a problem hiding this comment.
Updated.
I didn't update it was because this API is added from 3.4.0 for Connect but deprecated since 3.4.0, which becomes a bit confusing.
HyukjinKwon
approved these changes
Feb 25, 2023
Contributor
|
Merging. Thanks! |
hvanhovell
pushed a commit
that referenced
this pull request
Feb 25, 2023
### What changes were proposed in this pull request? Add temp view API to Dataset ### Why are the changes needed? API coverage ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes #40167 from amaliujia/add_temp_view_api. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 710e7de) Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Add temp view API to Dataset ### Why are the changes needed? API coverage ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#40167 from amaliujia/add_temp_view_api. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 710e7de) Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add temp view API to Dataset
Why are the changes needed?
API coverage
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT