[SPARK-42560][CONNECT] Add ColumnName class #40179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Feb 27, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Column.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Feb 27, 2023
hvanhovell
commented
Feb 27, 2023
| ProblemFilters.exclude[Problem]("org.apache.spark.sql.functions.typedLit"), | ||
|
|
||
| // RelationalGroupedDataset | ||
| ProblemFilters.exclude[Problem]("org.apache.spark.sql.RelationalGroupedDataset.apply"), |
Contributor
Author
There was a problem hiding this comment.
@zhenlineo why didn't this fail during CI?
Member
There was a problem hiding this comment.
Thank you so much for fixing this, @hvanhovell ! I also spent some time to dig this.
Contributor
Author
|
Merging. |
hvanhovell
added a commit
that referenced
this pull request
Feb 27, 2023
### What changes were proposed in this pull request? This PR adds the ColumnName for the Spark Connect Scala Client. This is a stepping stone to implement the SQLImplicits. ### Why are the changes needed? API parity with the current API. ### Does this PR introduce _any_ user-facing change? Yes. It adds new API. ### How was this patch tested? Added existing tests tot `ColumnTestSuite`. Closes #40179 from hvanhovell/SPARK-42560. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 24f0c45) Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR adds the ColumnName for the Spark Connect Scala Client. This is a stepping stone to implement the SQLImplicits. ### Why are the changes needed? API parity with the current API. ### Does this PR introduce _any_ user-facing change? Yes. It adds new API. ### How was this patch tested? Added existing tests tot `ColumnTestSuite`. Closes apache#40179 from hvanhovell/SPARK-42560. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 24f0c45) Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the ColumnName for the Spark Connect Scala Client. This is a stepping stone to implement the SQLImplicits.
Why are the changes needed?
API parity with the current API.
Does this PR introduce any user-facing change?
Yes. It adds new API.
How was this patch tested?
Added existing tests tot
ColumnTestSuite.