Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 27, 2023

What changes were proposed in this pull request?

This is a follow-up of #40180.

Why are the changes needed?

At previous PR, Scalastyle is checked but scalafmt was missed at the last commit.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass all CI linter jobs.

@dongjoon-hyun
Copy link
Member Author

cc @viirya

@dongjoon-hyun
Copy link
Member Author

Now, it passed.
Screenshot 2023-02-26 at 7 25 33 PM

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @hvanhovell . Sorry for the troubles.

dongjoon-hyun added a commit that referenced this pull request Feb 27, 2023
### What changes were proposed in this pull request?

This is a follow-up of #40180.

### Why are the changes needed?

At previous PR, `Scalastyle` is checked but `scalafmt` was missed at the last commit.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass all CI linter jobs.

Closes #40183 from dongjoon-hyun/SPARK-42587-2.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 379cb71)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

Merged to master/3.4.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-42587-2 branch February 27, 2023 03:51
@viirya
Copy link
Member

viirya commented Feb 27, 2023

Looks good.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya . Sorry for missing at the first PR.

snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
### What changes were proposed in this pull request?

This is a follow-up of apache#40180.

### Why are the changes needed?

At previous PR, `Scalastyle` is checked but `scalafmt` was missed at the last commit.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass all CI linter jobs.

Closes apache#40183 from dongjoon-hyun/SPARK-42587-2.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 379cb71)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants