Skip to content

Conversation

@WweiL
Copy link
Contributor

@WweiL WweiL commented Feb 27, 2023

What changes were proposed in this pull request?

#40073 accidentally changed the relationship of the two if statement in StateStoreProvider.validateStateRowFormat. Before they were inclusive, i.e.

if (a) {
  // <code>
  if (b) {
    // <code>
  }
}

It was changed to parallel, i.e.

if (a) {
  // <code>
}
if (b) {
    // <code>
}

This PR change it back to the original behavior and add a unit test to prevent it in the future.

Why are the changes needed?

As above.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test

@HeartSaVioR HeartSaVioR changed the title [SPARK-42572] [SQL] [SS] Fix behavior for StateStoreProvider.validateStateRowFormat [SPARK-42572][SQL][SS] Fix behavior for StateStoreProvider.validateStateRowFormat Feb 27, 2023
@WweiL WweiL requested a review from HeartSaVioR February 27, 2023 18:14
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@HeartSaVioR
Copy link
Contributor

Thanks! Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants