[SPARK-42337][SQL][FOLLOWUP] Update the error message for INVALID_TEMP_OBJ_REFERENCE #40198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Feb 28, 2023
| "INVALID_TEMP_OBJ_REFERENCE" : { | ||
| "message" : [ | ||
| "Cannot create a persistent <obj> <objName> by referencing a temporary <tempObj> <tempObjName>. Please make the temporary <tempObj> persistent, or make the persistent <obj> temporary." | ||
| "Cannot create a persistent object <objName> of type <obj> because it references a temporary object <tempObjName> of type <tempObj>. Please make the temporary object <tempObjName> persistent, or make the persistent object <objName> temporary." |
Member
There was a problem hiding this comment.
Suggested change
| "Cannot create a persistent object <objName> of type <obj> because it references a temporary object <tempObjName> of type <tempObj>. Please make the temporary object <tempObjName> persistent, or make the persistent object <objName> temporary." | |
| "Cannot create the persistent object <objName> of the type <obj> because it references to the temporary object <tempObjName> of the type <tempObj>. Please, make the temporary object <tempObjName> persistent, or make the persistent object <objName> temporary." |
Contributor
Author
|
cc @srielau |
MaxGekk
approved these changes
Mar 1, 2023
Member
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up for #39910. It updates the error message of the error class INVALID_TEMP_OBJ_REFERENCE.
Why are the changes needed?
To make the error message more user-friendly.
Does this PR introduce any user-facing change?
Yes. This PR updates the error message for INVALID_TEMP_OBJ_REFERENCE.
How was this patch tested?
Existing tests