Skip to content

[SPARK-42478][SQL][3.2] Make a serializable jobTrackerId instead of a non-serializable JobID in FileWriterFactory #40289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yikf wants to merge 1 commit into from
Closed

[SPARK-42478][SQL][3.2] Make a serializable jobTrackerId instead of a non-serializable JobID in FileWriterFactory #40289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileWriterFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ case class FileWriterFactory (
description: WriteJobDescription,
committer: FileCommitProtocol) extends DataWriterFactory {

private val jobId = SparkHadoopWriterUtils.createJobID(new Date, 0)
// SPARK-42478: jobId across tasks should be consistent to meet the contract
// expected by Hadoop committers, but `JobId` cannot be serialized.
// thus, persist the serializable jobTrackerID in the class and make jobId a
// transient lazy val which recreates it each time to ensure jobId is unique.
private[this] val jobTrackerID = SparkHadoopWriterUtils.createJobTrackerID(new Date)
@transient private lazy val jobId = SparkHadoopWriterUtils.createJobID(jobTrackerID, 0)

override def createWriter(partitionId: Int, realTaskId: Long): DataWriter[InternalRow] = {
val taskAttemptContext = createTaskAttemptContext(partitionId)
Expand Down