[SPARK-42664][CONNECT] Support bloomFilter function for DataFrameStatFunctions
#40352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Mar 9, 2023
...connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala
Outdated
Show resolved
Hide resolved
LuciferYang
changed the title
bloomFilter function for DataFrameStatFunctionsbloomFilter function for DataFrameStatFunctions
hvanhovell
reviewed
Mar 9, 2023
...connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Mar 9, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Mar 9, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Mar 9, 2023
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala
Outdated
Show resolved
Hide resolved
LuciferYang
commented
Mar 10, 2023
| numBits: Long, | ||
| fpp: Double): BloomFilter = { | ||
|
|
||
| val dataType = sparkSession |
Contributor
Author
There was a problem hiding this comment.
Add this due to:
- check
colsupport type in server side - Add
Castfor IntegerType/ShortType/ByteType
Contributor
There was a problem hiding this comment.
Can we use the TypeOf expression for this instead? Alternatively we can try to figure this out in the planner.
LuciferYang
commented
Mar 10, 2023
...connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Outdated
Show resolved
Hide resolved
LuciferYang
changed the title
bloomFilter function for DataFrameStatFunctionsbloomFilter function for DataFrameStatFunctions
hvanhovell
reviewed
Apr 7, 2023
...connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Apr 7, 2023
...rc/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/BloomFilterAggregate.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
In the last commit, make |
Contributor
Author
|
GA failure is not related to the current PR |
LuciferYang
commented
Apr 7, 2023
| numBits: Long, | ||
| fpp: Double): BloomFilter = { | ||
|
|
||
| val agg = if (!fpp.isNaN) { |
Contributor
Author
There was a problem hiding this comment.
Before chanage to always pass 3 parameters, always pass all 4 parameters.
Now change to pass (col, expectedNumItems, fpp) if !fpp. isNaN , otherwise pass (col, expectedNumItems, numBits).
Contributor
|
@LuciferYang can we restart this effort. I promise I will look at the proto PR :) |
Contributor
Author
|
This pr has been rebased many times, should I submit a new one... |
Contributor
Author
|
I make a clean one #42414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is pr using
BloomFilterAggregateto implementbloomFilterfunction forDataFrameStatFunctions.Why are the changes needed?
Add Spark connect jvm client api coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?