Skip to content

Conversation

@pwendell
Copy link
Contributor

There are two relevant 'skip' configurations in the build, the first
is for "mvn install" and the second is for "mvn deploy". As of 1.2,
we actually use "mvn install" to generate our deployed artifcts,
because we have some customization of the nexus upload due to having
to cross compile for Scala 2.10 and 2.11.

There is no reason to have differents settings for these values,
this patch simply cleans this up for the repl/ and yarn/
projects.

@SparkQA
Copy link

SparkQA commented Jan 16, 2015

Test build #25685 has started for PR 4080 at commit e65581c.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor Author

Sorry (@srowen, @vanzin) - made a mistake on the old PR and had to open a new one here.

@SparkQA
Copy link

SparkQA commented Jan 16, 2015

Test build #25685 has finished for PR 4080 at commit e65581c.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class SparkListenerJobEnd(
    • class SparkILoop(
    • * @param id The id (variable name, method name, class name, etc) whose
    • * Retrieves the class representing the id (variable name, method name,
    • * @param id The id (variable name, method name, class name, etc) whose
    • * @return Some containing term name (id) class if exists, else None
    • * @param id The id (variable name, method name, class name, etc) whose
    • * @param id The id (variable name, method name, class name, etc) whose
    • * Retrieves the runtime class and type representing the id (variable name,
    • * @param id The id (variable name, method name, class name, etc) whose
    • * @param id The id (variable name, method name, class name, etc) whose

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25685/
Test FAILed.

There are two relevant 'skip' configurations in the build, the first
is for "mvn install" and the second is for "mvn deploy". As of 1.2,
we actually use "mvn install" to generate our deployed artifcts,
because we have some customization of the nexus upload due to having
to cross compile for Scala 2.10 and 2.11.

There is no reason to have differents settings for these values,
this patch simply cleans this up for the repl/ and yarn/
projects.
@pwendell
Copy link
Contributor Author

@srowen my comment on the old one was that, since companies probably still use the traditional deploy pattern internally (e.g. they aren't doing anything fancy to cross build), I think it's fine to keep both settings throughout.

@pwendell
Copy link
Contributor Author

Jenkins, test this please.

@srowen
Copy link
Member

srowen commented Jan 16, 2015

OK I think you're more aware of the usage. It should basically mirror the install config right?

@SparkQA
Copy link

SparkQA commented Jan 16, 2015

Test build #25686 has started for PR 4080 at commit e21b78b.

  • This patch merges cleanly.

@vanzin
Copy link
Contributor

vanzin commented Jan 16, 2015

Hi Patrick,

This looks ok to me, but could you look at my comment in #4078? I'm not familiar with the Spark deploy scripts and I'm afraid I may have broken something there inadvertently.

@pwendell
Copy link
Contributor Author

@vanzin yeah I think it was fine that you removed the install skop. We wanted to do that anyways because some people requested that we continue to publish those artifacts. This patch simply brings the deploy in sync with install.

@pwendell
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jan 16, 2015

Test build #25688 has started for PR 4080 at commit e21b78b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 16, 2015

Test build #25686 has finished for PR 4080 at commit e21b78b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25686/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 17, 2015

Test build #25688 has finished for PR 4080 at commit e21b78b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25688/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants