-
Notifications
You must be signed in to change notification settings - Fork 29k
[HOTFIX]: Minor clean up regarding skipped artifacts in build files. #4080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #25685 has started for PR 4080 at commit
|
|
Test build #25685 has finished for PR 4080 at commit
|
|
Test FAILed. |
There are two relevant 'skip' configurations in the build, the first is for "mvn install" and the second is for "mvn deploy". As of 1.2, we actually use "mvn install" to generate our deployed artifcts, because we have some customization of the nexus upload due to having to cross compile for Scala 2.10 and 2.11. There is no reason to have differents settings for these values, this patch simply cleans this up for the repl/ and yarn/ projects.
|
@srowen my comment on the old one was that, since companies probably still use the traditional deploy pattern internally (e.g. they aren't doing anything fancy to cross build), I think it's fine to keep both settings throughout. |
|
Jenkins, test this please. |
|
OK I think you're more aware of the usage. It should basically mirror the install config right? |
|
Test build #25686 has started for PR 4080 at commit
|
|
Hi Patrick, This looks ok to me, but could you look at my comment in #4078? I'm not familiar with the Spark deploy scripts and I'm afraid I may have broken something there inadvertently. |
|
@vanzin yeah I think it was fine that you removed the install skop. We wanted to do that anyways because some people requested that we continue to publish those artifacts. This patch simply brings the deploy in sync with install. |
|
Jenkins, test this please. |
|
Test build #25688 has started for PR 4080 at commit
|
|
Test build #25686 has finished for PR 4080 at commit
|
|
Test PASSed. |
|
Test build #25688 has finished for PR 4080 at commit
|
|
Test PASSed. |
There are two relevant 'skip' configurations in the build, the first
is for "mvn install" and the second is for "mvn deploy". As of 1.2,
we actually use "mvn install" to generate our deployed artifcts,
because we have some customization of the nexus upload due to having
to cross compile for Scala 2.10 and 2.11.
There is no reason to have differents settings for these values,
this patch simply cleans this up for the repl/ and yarn/
projects.