Skip to content

[SPARK-42419][FOLLOWUP][CONNECT][PYTHON] Remove unused exception #40927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itholic wants to merge 3 commits into from
Closed

[SPARK-42419][FOLLOWUP][CONNECT][PYTHON] Remove unused exception #40927

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44b1ef1
[SPARK-42419][FOLLOWUP] Remove unused exception
itholic Apr 24, 2023
b35fbe5
Fix
itholic Apr 25, 2023
c639137
fix linter
itholic Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions python/pyspark/sql/connect/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,24 +239,15 @@ def substr(self, startPos: Union[int, "Column"], length: Union[int, "Column"]) -

if isinstance(length, Column):
length_expr = length._expr
start_expr = startPos._expr # type: ignore[union-attr]
elif isinstance(length, int):
length_expr = LiteralExpression._from_value(length)
else:
raise PySparkTypeError(
error_class="NOT_COLUMN_OR_INT",
message_parameters={"arg_name": "length", "arg_type": type(length).__name__},
)

if isinstance(startPos, Column):
start_expr = startPos._expr
elif isinstance(startPos, int):
start_expr = LiteralExpression._from_value(startPos)
else:
raise PySparkTypeError(
error_class="NOT_COLUMN_OR_INT",
message_parameters={"arg_name": "startPos", "arg_type": type(startPos).__name__},
message_parameters={"arg_name": "length", "arg_type": type(length).__name__},
)

return Column(UnresolvedFunction("substring", [self._expr, start_expr, length_expr]))

substr.__doc__ = PySparkColumn.substr.__doc__
Expand Down