Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api #41340

Closed
wants to merge 3 commits into from
Closed

[SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api #41340

wants to merge 3 commits into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented May 27, 2023 •
edited
Loading

What changes were proposed in this pull request?

The pr aims to remove useless dependencies - javax.ws.rs-api.

Why are the changes needed?

Make code and dependency concisely.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@github-actions github-actions bot added the BUILD label May 27, 2023
@LuciferYang
Copy link
Contributor

@panbingkun Can you explain why these two dependencies are no longer useful?

@dongjoon-hyun dongjoon-hyun marked this pull request as draft May 28, 2023 02:35
@panbingkun panbingkun changed the title [WIP] Remove some dependency in pom [SPARK-44318][BUILD] Remove useless dependencies - javax.ws.rs-api Jul 6, 2023
@panbingkun
Copy link
Contributor Author

1.(Jersey depend on it) The first PR to introduce the dependency of javax.ws.rs.javax.ws.rs-api
PR: [SPARK-12154] Upgrade to Jersey 2
CommitID: b7fdc23

b7fdc23#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R624-R627
image

2.Because Jersey depends on it, however, with the upgrade of Jersey version, the rs-api package name it depends on has been moved from: javax.ws.rs.javax.ws.rs-api to: jakarta.ws.rs.jakarta.ws.rs-api in version 2.28, but there is no corresponding removal in Spark.

image image
image

4.In fact, we can only depends on [jakarta.ws.rs](https://mvnrepository.com/artifact/jakarta.ws.rs) » [jakarta.ws.rs-api](https://mvnrepository.com/artifact/jakarta.ws.rs/jakarta.ws.rs-api) in Spark because its package name has changed.

@panbingkun panbingkun marked this pull request as ready for review July 6, 2023 07:08
@panbingkun
Copy link
Contributor Author

cc @LuciferYang @dongjoon-hyun

@dongjoon-hyun
Copy link
Member

There is no change on dependency manifest file?

@panbingkun
Copy link
Contributor Author

There is no change on dependency manifest file?

Yes, that's right, it doesn't exist in spark-deps-hadoop-3-hive-2.3.
Only the changed package exists:
image

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Oct 15, 2023
@github-actions github-actions bot closed this Oct 16, 2023
@hiufung-kwok hiufung-kwok mentioned this pull request Oct 15, 2024
Closed
dongjoon-hyun pushed a commit that referenced this pull request Oct 15, 2024
@hiufung-kwok @dongjoon-hyun
[SPARK-49964][BUILD] Remove ws-rs-api package
111473d 
### What changes were proposed in this pull request?

- To Remove the dependency of `javax.ws.rs.ws-rs-api` as it's no longer required.

Prior discussion can be found on:
 - #41340
 - #45154

### Why are the changes needed?
In the past, the codebase used to have a few .scala classes referencing and using the `ws-rs-api`, such as b7fdc23#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R624-R627

However as the time passed by, all usages of `ws-rs-api` are either got removed / refactored. Hence there is no need to have it import on root POM as now and we can always re-introduce it later, if the usage can be justified again.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Unit-test, to make sure the codebase is not impacted by the removal of the dependency.

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #48461 from hiufung-kwok/ft-hf-SPARK-49963-remove-ws-rs-api.

Authored-by: HiuFung Kwok <hiufung.kwok.852@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
@hiufung-kwok
[SPARK-49964][BUILD] Remove ws-rs-api package
31038c3 
### What changes were proposed in this pull request?

- To Remove the dependency of `javax.ws.rs.ws-rs-api` as it's no longer required.

Prior discussion can be found on:
 - apache#41340
 - apache#45154

### Why are the changes needed?
In the past, the codebase used to have a few .scala classes referencing and using the `ws-rs-api`, such as apache@b7fdc23#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R624-R627

However as the time passed by, all usages of `ws-rs-api` are either got removed / refactored. Hence there is no need to have it import on root POM as now and we can always re-introduce it later, if the usage can be justified again.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Unit-test, to make sure the codebase is not impacted by the removal of the dependency.

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#48461 from hiufung-kwok/ft-hf-SPARK-49963-remove-ws-rs-api.

Authored-by: HiuFung Kwok <hiufung.kwok.852@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BUILD Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panbingkun @LuciferYang @dongjoon-hyun