Revert [SPARK-43836][SPARK-43845][SPARK-43858][SPARK-43858] to keep Scala 2.12 for Spark 3.x #41416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ala 2.13 as default" This reverts commit 8e18d68.
This reverts commit f91136a.
This reverts commit a9f13e1.
This reverts commit 1e9b0f6.
This pr aims to enable `unused imports` check for Scala 2.13. There is an exception here for `import scala.language.higherKinds`（Scala 2.13 does not need to import them , while Scala 2.12 must import them）, so this pr add two new suppression rules for it. Enable `unused imports` check for Scala 2.13. No. Pass Github Actions Closes #41356 from LuciferYang/SPARK-43849. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
….13 after run benchmark" This reverts commit ce568b7.
dongjoon-hyun
changed the title
|
Thank you, @HyukjinKwon . Also, cc @srowen , @LuciferYang . |
|
So we needn't to update the benchmark results for Scala 2.13 for now, right? I'll close SPARK-43857 |
|
We may keep them in a separate directory or different file names later. But, yes, we are unable to overwrite them for now.. Sorry for that. |
Got it, Let's wait ~ |
|
Thank you. Merged to master. |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…cala 2.12 for Spark 3.x ### What changes were proposed in this pull request? This PR aims to revert the following 4 commits effectively. SPARK-43836 Make Scala 2.13 as default in Spark 3.5 SPARK-43845 Setup Scala 2.12 Daily GitHub Action Job SPARK-43858 Make benchmark Github Action task use Scala 2.13 as default SPARK-43858 Restore the Scala version to 2.13 after run benchmark ### Why are the changes needed? According to the dev mailing list discussion, we keep the Scala 2.12 for Spark 3.x. - https://lists.apache.org/thread/xz7x0nkjn1d13yl9on59lfttm6f0yd45 We open a new thread, "Apache Spark 4.0 Timeframe?", for Spark 4 planning. - https://lists.apache.org/thread/xhkgj60j361gdpywoxxz7qspp2w80ry6 ### Does this PR introduce _any_ user-facing change? No. This is a recovery to the existing behavior. ### How was this patch tested? Pass the CIs. Closes apache#41416 from dongjoon-hyun/revert-2.13. Lead-authored-by: Dongjoon Hyun <dongjoon@apache.org> Co-authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to revert the following 4 commits effectively.
SPARK-43836 Make Scala 2.13 as default in Spark 3.5
SPARK-43845 Setup Scala 2.12 Daily GitHub Action Job
SPARK-43858 Make benchmark Github Action task use Scala 2.13 as default
SPARK-43858 Restore the Scala version to 2.13 after run benchmark
Why are the changes needed?
According to the dev mailing list discussion, we keep the Scala 2.12 for Spark 3.x.
We open a new thread, "Apache Spark 4.0 Timeframe?", for Spark 4 planning.
Does this PR introduce any user-facing change?
No. This is a recovery to the existing behavior.
How was this patch tested?
Pass the CIs.