SPARK-5308 [BUILD] MD5 / SHA1 hash format doesn't match standard Maven output #4161
Conversation
|
Test build #25968 has started for PR 4161 at commit
|
|
Test build #25968 has finished for PR 4161 at commit
|
|
Test PASSed. |
dev/create-release/create-release.sh
Outdated
There was a problem hiding this comment.
Minor style comment: Could we use $(...) instead of backticks? I believe use of backticks is discouraged in bash.
|
Test build #25973 has started for PR 4161 at commit
|
|
Test build #25973 has finished for PR 4161 at commit
|
|
Test PASSed. |
|
Thanks Sean - pulling this in. |
…n output Here's one way to make the hashes match what Maven's plugins would create. It takes a little extra footwork since OS X doesn't have the same command line tools. An alternative is just to make Maven output these of course - would that be better? I ask in case there is a reason I'm missing, like, we need to hash files that Maven doesn't build. Author: Sean Owen <sowen@cloudera.com> Closes #4161 from srowen/SPARK-5308 and squashes the following commits: 70d09d0 [Sean Owen] Use $(...) syntax e25eff8 [Sean Owen] Generate MD5, SHA1 hashes in a format like Maven's plugin (cherry picked from commit ff356e2) Signed-off-by: Patrick Wendell <patrick@databricks.com>
5 participants
Here's one way to make the hashes match what Maven's plugins would create. It takes a little extra footwork since OS X doesn't have the same command line tools. An alternative is just to make Maven output these of course - would that be better? I ask in case there is a reason I'm missing, like, we need to hash files that Maven doesn't build.