[SPARK-44313][SQL] Fix generated column expression validation when there is a char/varchar column in the schema #41868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonport-db
changed the title
cloud-fan
approved these changes
Jul 5, 2023
yaooqinn
approved these changes
Jul 6, 2023
yaooqinn
pushed a commit
that referenced
this pull request
Jul 6, 2023
…ere is a char/varchar column in the schema ### What changes were proposed in this pull request? #38823 added support for defining generated columns in create table statements. This included generation expression validation. This validation currently erroneously fails when there are char or varchar columns anywhere in the table schema since the checkAnalysis fails here https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GeneratedColumn.scala#L123. This PR replaces any char/varchar columns in the schema with a string before analysis. ### Why are the changes needed? This should not fail. ``` CREATE TABLE default.example ( name VARCHAR(64), tstamp TIMESTAMP, tstamp_date DATE GENERATED ALWAYS AS (CAST(tstamp as DATE)) ) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Adds a unit test. Closes #41868 from allisonport-db/validateGeneratedColumns-charvarchar. Authored-by: Allison Portis <allison.portis@databricks.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit f0e1828) Signed-off-by: Kent Yao <yao@apache.org>
Member
|
thanks @allisonport-db @cloud-fan @ShreyeshArangath merged to master and 3.4 |
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
…ere is a char/varchar column in the schema ### What changes were proposed in this pull request? apache#38823 added support for defining generated columns in create table statements. This included generation expression validation. This validation currently erroneously fails when there are char or varchar columns anywhere in the table schema since the checkAnalysis fails here https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GeneratedColumn.scala#L123. This PR replaces any char/varchar columns in the schema with a string before analysis. ### Why are the changes needed? This should not fail. ``` CREATE TABLE default.example ( name VARCHAR(64), tstamp TIMESTAMP, tstamp_date DATE GENERATED ALWAYS AS (CAST(tstamp as DATE)) ) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Adds a unit test. Closes apache#41868 from allisonport-db/validateGeneratedColumns-charvarchar. Authored-by: Allison Portis <allison.portis@databricks.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit f0e1828) Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#38823 added support for defining generated columns in create table statements. This included generation expression validation. This validation currently erroneously fails when there are char or varchar columns anywhere in the table schema since the checkAnalysis fails here https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GeneratedColumn.scala#L123.
This PR replaces any char/varchar columns in the schema with a string before analysis.
Why are the changes needed?
This should not fail.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Adds a unit test.