[SPARK-44439][CONNECT][SS]Fixed listListeners to only send ids back to client#42013
Closed
bogao007 wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-44439][CONNECT][SS]Fixed listListeners to only send ids back to client#42013bogao007 wants to merge 5 commits intoapache:masterfrom
bogao007 wants to merge 5 commits intoapache:masterfrom
Conversation
bogao007
commented
Jul 14, 2023
| private[sql] class StreamingQueryStatusListener( | ||
| @transient val conf: SparkConf, | ||
| @transient val store: ElementTrackingStore) extends StreamingQueryListener { | ||
| val conf: SparkConf, |
rangadi
approved these changes
Jul 14, 2023
rangadi
left a comment
There was a problem hiding this comment.
Thanks for removing a lot of code.
Suggested a change for protobuf field. LGTM with that.
connector/connect/common/src/main/protobuf/spark/connect/commands.proto
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Jul 17, 2023
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes listListener that's being implemented in a previous PR that sends listener class payload to client. We will only send ids as references of listener classes to client side instead.
Why are the changes needed?
We should only return what users added previously in
listListenersAPI. Only sending ids would be much more light-weighted.Does this PR introduce any user-facing change?
yes
How was this patch tested?
Unit tested.
Also performed manual integration test