[SPARK-43755][CONNECT][MINOR] Open AdaptiveSparkPlanHelper.allChildren instead of using copy in MetricGenerator
#42060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HyukjinKwon @xuanyuanking this is a tiny followup to code that got refactored in #41315. It could be considered for branch-3.5 to keep the two in sync? |
juliuszsompolski
changed the title
AdaptiveSparkPlanHelper.allChildren instead of copyingAdaptiveSparkPlanHelper.allChildren instead of using copy in MetricGenerator
juliuszsompolski
changed the title
AdaptiveSparkPlanHelper.allChildren instead of using copy in MetricGenerator AdaptiveSparkPlanHelper.allChildren instead of using copy in MetricGenerator
HyukjinKwon
approved these changes
Jul 19, 2023
Member
|
Merged to master and branch-3.5. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 19, 2023
…en` instead of using copy in `MetricGenerator` ### What changes were proposed in this pull request? Minor refactor - make `AdaptiveSparkPlanHelper.allChildren` protected in place of private, so that we don't have to copy it over, risking that the two versions will get out of sync. ### Why are the changes needed? Minor refactor. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI Closes #42060 from juliuszsompolski/SPARK-43755-fup. Authored-by: Juliusz Sompolski <julek@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 227e28c) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor refactor - make
AdaptiveSparkPlanHelper.allChildrenprotected in place of private, so that we don't have to copy it over, risking that the two versions will get out of sync.Why are the changes needed?
Minor refactor.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI