[SPARK-44474][CONNECT] Reenable "Test observe response" at SparkConnectServiceSuite #42063
+22
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesjean
force-pushed
the
SPARK-44474
branch
4 times, most recently
from
0120502 to
08a5122
Compare
jdesjean
changed the title
juliuszsompolski
approved these changes
Jul 18, 2023
HyukjinKwon
approved these changes
Jul 19, 2023
Member
|
Merged to master and branch-3.5. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 19, 2023
…ctServiceSuite ### What changes were proposed in this pull request? Finished is emitted in SparkConnectPlanExecution after the arrow conversion job is completed. However, since we don't await the completion of the job, it's possible for SparkConnectPlanExecution to complete before sending Finished. Closed is emitted in SparkConnectExecutePlanHandler in a separate thread. Add await in order to guarantee the order of events between Finished & Closed. ### Why are the changes needed? `Test observe response` at SparkConnectServiceSuite was disabled as flaky after [introduction of events](#41443). Failure surfaced race condition in emitting the Finished & Closed events for Connect request of type plan. The correct order of events is Finished < Closed. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit Closes #42063 from jdesjean/SPARK-44474. Authored-by: jdesjean <jf.gauthier@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit cf99e6c) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Finished is emitted in SparkConnectPlanExecution after the arrow conversion job is completed. However, since we don't await the completion of the job, it's possible for SparkConnectPlanExecution to complete before sending Finished.
Closed is emitted in SparkConnectExecutePlanHandler in a separate thread.
Add await in order to guarantee the order of events between Finished & Closed.
Why are the changes needed?
Test observe responseat SparkConnectServiceSuite was disabled as flaky after introduction of events. Failure surfaced race condition in emitting the Finished & Closed events for Connect request of type plan. The correct order of events is Finished < Closed.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit