[SPARK-44490][WEBUI] Remove unused TaskPagedTable in StagePage
#42085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@LuciferYang Please help to review, thanks. |
Contributor
|
also cc @yaooqinn FYI |
Member
|
Could you please attach one or more screenshots in the description? |
Contributor
Author
PR
|
Member
sarutak
reviewed
Jul 28, 2023
Member
There was a problem hiding this comment.
Thank you. It's reasonable to avoid the calsulation if the timeline feature is disabled.
Member
|
@cxzl25 Could you attach another screenshot showing a task table which consists of multiple pages to verify it works with pagenation? |
Contributor
Author
|
yaooqinn
approved these changes
Aug 1, 2023
Member
|
Hi @cxzl25, would you please rebase the master branch? |
yaooqinn
changed the title
TaskPagedTable in StagePageTaskPagedTable in StagePage
Member
|
Merging to |
LuciferYang
added a commit
that referenced
this pull request
Jan 29, 2025
…eSuite.scala` ### What changes were proposed in this pull request? This pr removes a test file `StagePageSuite.scala` that is no longer needed. ### Why are the changes needed? The current `StagePageSuite.scala` contains one test case and one private method. The reasons for cleaning them up are as follows: 1. The assertion in the test case "ApiHelper.COLUMN_TO_INDEX should match headers of the task table" was cleaned up in SPARK-44490 | #42085. Currently, this test case only creates a `StageData` object and an `AppStatusStore` object, with no other operations or assertions. Moreover, the creation of these objects is also covered in other test cases, such as `KVStoreProtobufSerializerSuite`, `AppStatusStoreSuite`, etc. Therefore, this is already an unnecessary test case and can be cleaned up. 2. The private method `renderStagePage` has not been used since SPARK-21809 | #21688, so it can be cleaned up. After cleaning up the above content, `StagePageSuite.scala` becomes an empty file, so it can be completely deleted. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #49721 from LuciferYang/SPARK-51026. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
LuciferYang
added a commit
that referenced
this pull request
Jan 29, 2025
…eSuite.scala` ### What changes were proposed in this pull request? This pr removes a test file `StagePageSuite.scala` that is no longer needed. ### Why are the changes needed? The current `StagePageSuite.scala` contains one test case and one private method. The reasons for cleaning them up are as follows: 1. The assertion in the test case "ApiHelper.COLUMN_TO_INDEX should match headers of the task table" was cleaned up in SPARK-44490 | #42085. Currently, this test case only creates a `StageData` object and an `AppStatusStore` object, with no other operations or assertions. Moreover, the creation of these objects is also covered in other test cases, such as `KVStoreProtobufSerializerSuite`, `AppStatusStoreSuite`, etc. Therefore, this is already an unnecessary test case and can be cleaned up. 2. The private method `renderStagePage` has not been used since SPARK-21809 | #21688, so it can be cleaned up. After cleaning up the above content, `StagePageSuite.scala` becomes an empty file, so it can be completely deleted. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #49721 from LuciferYang/SPARK-51026. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com> (cherry picked from commit 3badfd2) Signed-off-by: yangjie01 <yangjie01@baidu.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…eSuite.scala` ### What changes were proposed in this pull request? This pr removes a test file `StagePageSuite.scala` that is no longer needed. ### Why are the changes needed? The current `StagePageSuite.scala` contains one test case and one private method. The reasons for cleaning them up are as follows: 1. The assertion in the test case "ApiHelper.COLUMN_TO_INDEX should match headers of the task table" was cleaned up in SPARK-44490 | apache#42085. Currently, this test case only creates a `StageData` object and an `AppStatusStore` object, with no other operations or assertions. Moreover, the creation of these objects is also covered in other test cases, such as `KVStoreProtobufSerializerSuite`, `AppStatusStoreSuite`, etc. Therefore, this is already an unnecessary test case and can be cleaned up. 2. The private method `renderStagePage` has not been used since SPARK-21809 | apache#21688, so it can be cleaned up. After cleaning up the above content, `StagePageSuite.scala` becomes an empty file, so it can be completely deleted. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49721 from LuciferYang/SPARK-51026. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com> (cherry picked from commit fb742ff) Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove
TaskPagedTableWhy are the changes needed?
In SPARK-21809, we introduced
stagespage-template.htmlto show the running status of Stage.TaskPagedTableis no longer effective, but there are still many PRs updating related codes.Does this PR introduce any user-facing change?
No
How was this patch tested?
local test