Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Jul 31, 2023

What changes were proposed in this pull request?

Make Analyzer rule WidenSetOperationTypes retains the Plan_ID_TAG

Why are the changes needed?

for functionality parity

Does this PR introduce any user-facing change?

yes, APIs enabled:

  1. frame.append
  2. series.argsort
  3. ps.concat

How was this patch tested?

enabled UTs

@zhengruifeng zhengruifeng changed the title [SPARK-44602][SQL][CONNECT][PS] Make WidenSetOperationTypes retains the Plan_ID_TAG [SPARK-44602][SQL][CONNECT][PS] Make WidenSetOperationTypes retain the Plan_ID_TAG Jul 31, 2023
@zhengruifeng
Copy link
Contributor Author

cc @HyukjinKwon @cloud-fan @itholic

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 31, 2023

Merged to master.

@HyukjinKwon
Copy link
Member

Should we merge this to 3.5 too? It depends on #42086

@zhengruifeng zhengruifeng deleted the ps_connect_analyze_union branch July 31, 2023 11:10
@zhengruifeng
Copy link
Contributor Author

cc @itholic should we backport this PR and #42086 to 3.5?

If so, would you mind helping backporting them?

@itholic
Copy link
Contributor

itholic commented Jul 31, 2023

Yes, it would be great to have this one for 3.5. Let me create a backport PRs soon.

@itholic
Copy link
Contributor

itholic commented Aug 1, 2023

Made a backport PR for both #42086 and this : #42252

zhengruifeng added a commit that referenced this pull request Aug 1, 2023
…wExpressions` & `WidenSetOperationTypes` retain the `PLAN_ID_TAG`

### What changes were proposed in this pull request?

Backport for #42086 and #42230

### Why are the changes needed?

for functionality parity

### Does this PR introduce _any_ user-facing change?

Enabling couple of pandas APIs

### How was this patch tested?

Enabling the existing UTs

Closes #42252 from itholic/SPARK-43611-3.5.

Lead-authored-by: Ruifeng Zheng <ruifengz@apache.org>
Co-authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants