[SPARK-44289][SPARK-43874][SPARK-43869][SPARK-43607][PS] Support indexer_between_time for pandas 2.0.0 & enabling more tests.
#42533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Aug 18, 2023
|
merged to master |
zhengruifeng
pushed a commit
that referenced
this pull request
Aug 18, 2023
### What changes were proposed in this pull request? This is followup for #42533 to remove meaningless import ### Why are the changes needed? import numpy is not needed for doctest. ### Does this PR introduce _any_ user-facing change? This impacts to user-facing documents, so it's sort of user-facing cleanup. ### How was this patch tested? The existing CI should pass Closes #42552 from itholic/test-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…exer_between_time` for pandas 2.0.0 & enabling more tests ### What changes were proposed in this pull request? This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail. This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`. ### Why are the changes needed? To match the behavior with latest pandas. ### Does this PR introduce _any_ user-facing change? `DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas. ### How was this patch tested? Enabling & updating the existing UTs and doctests. Closes apache#42533 from itholic/enable-many-tests. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? This is followup for apache#42533 to remove meaningless import ### Why are the changes needed? import numpy is not needed for doctest. ### Does this PR introduce _any_ user-facing change? This impacts to user-facing documents, so it's sort of user-facing cleanup. ### How was this patch tested? The existing CI should pass Closes apache#42552 from itholic/test-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 15, 2023
…_multiindex_columns` ### What changes were proposed in this pull request? Follow-up for #42533. ### Why are the changes needed? To enable test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42941 from itholic/SPARK-43874-followup. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
a0x8o
added a commit
to a0x8o/spark
that referenced
this pull request
Sep 15, 2023
…_multiindex_columns` ### What changes were proposed in this pull request? Follow-up for apache/spark#42533. ### Why are the changes needed? To enable test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42941 from itholic/SPARK-43874-followup. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…exer_between_time` for pandas 2.0.0 & enabling more tests ### What changes were proposed in this pull request? This PR proposes to support `DatetimeIndex.indexer_between_time` to support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail. This PR also enables bunch of tests for `Series`, `Index` and `GroupBy`. ### Why are the changes needed? To match the behavior with latest pandas. ### Does this PR introduce _any_ user-facing change? `DatetimeIndex.indexer_between_time` now has the same behavior with the latest pandas. ### How was this patch tested? Enabling & updating the existing UTs and doctests. Closes apache#42533 from itholic/enable-many-tests. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This is followup for apache#42533 to remove meaningless import ### Why are the changes needed? import numpy is not needed for doctest. ### Does this PR introduce _any_ user-facing change? This impacts to user-facing documents, so it's sort of user-facing cleanup. ### How was this patch tested? The existing CI should pass Closes apache#42552 from itholic/test-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to support
DatetimeIndex.indexer_between_timeto support pandas 2.0.0 and above. See pandas-dev/pandas#43248 for more detail.This PR also enables bunch of tests for
Series,IndexandGroupBy.Why are the changes needed?
To match the behavior with latest pandas.
Does this PR introduce any user-facing change?
DatetimeIndex.indexer_between_timenow has the same behavior with the latest pandas.How was this patch tested?
Enabling & updating the existing UTs and doctests.