[SPARK-44863][UI][3.5] Add a button to download thread dump as a txt in Spark UI #42654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Aug 24, 2023
dongjoon-hyun
requested changes
Aug 24, 2023
Member
There was a problem hiding this comment.
I love your passion, @yaooqinn and @zhengruifeng, but we are in RC2 stage. This PR is a new feature completely and looks inappropriate to branch-3.5 at this time.
Member
|
In addition, this umbrella itself is for Apache Spark 4.0.0, isn't it? |
Contributor
|
@dongjoon-hyun yes, thanks for the reminder. @yaooqinn let's keep this feature only in master, sorry for asking for merging to 3.5 |
Member
Author
|
It's okay @zhengruifeng. And thank you, @dongjoon-hyun, for the clarification. |
Member
|
Thank you for the decision, @yaooqinn and @zhengruifeng . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR added a button to download thread dump as a txt w.r.t. jstack formatting
Why are the changes needed?
The formatting of raw jstack can be relatively easy to read and analyze using various thread tools.
Does this PR introduce any user-facing change?
How was this patch tested?
Raw Dump File
driver.txt
Reporting by external tools
https://fastthread.io/my-thread-report.jsp?p=c2hhcmVkLzIwMjMvMDgvMjAvZHJpdmVyLnR4dC0tMTMtNTMtMjI=&
Was this patch authored or co-authored using generative AI tooling?
no